Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing minecraft:enchantable/vanishing to c:enchantables #1494

Merged

Conversation

TelepathicGrunt
Copy link
Contributor

Makes sure the tag is fully complete.

Fabric PR: FabricMC/fabric#4058

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 26, 2024

  • Publish PR to GitHub Packages

Last commit published: c5d281fbad2fa8b7a59643ccbbcdafabbed0fd8f.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1494' // https://github.com/neoforged/NeoForge/pull/1494
        url 'https://prmaven.neoforged.net/NeoForge/pr1494'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1494.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1494
cd NeoForge-pr1494
curl -L https://prmaven.neoforged.net/NeoForge/pr1494/net/neoforged/neoforge/21.1.30-pr-1494-Add-vanishing-enchantables/mdk-pr1494.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt TelepathicGrunt merged commit 9b2c819 into neoforged:1.21.x Sep 1, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants