Passing RegistryAccess to more Events!
#1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sciwhiz12
added
enhancement
src/main/java/net/neoforged/neoforge/event/village/VillagerTradesEvent.java
Outdated
Show resolved
Hide resolved
XFactHD
requested changes
Sep 12, 2024
src/main/java/net/neoforged/neoforge/event/village/VillagerTradesEvent.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/village/WandererTradesEvent.java
Show resolved
Hide resolved
|
That should now return all the original methods and constructors, and mark them all as deprecated |
XFactHD
requested changes
Sep 13, 2024
patches/net/minecraft/world/item/alchemy/PotionBrewing.java.patch
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/village/VillagerTradesEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/village/WandererTradesEvent.java
Outdated
Show resolved
Hide resolved
|
Those have been added now too :) |
XFactHD
previously approved these changes
Sep 13, 2024
sciwhiz12
requested changes
Sep 15, 2024
patches/net/minecraft/world/item/alchemy/PotionBrewing.java.patch
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/village/VillagerTradesEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/village/VillagerTradesEvent.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/event/village/WandererTradesEvent.java
Show resolved
Hide resolved
|
@sciwhiz12 those changes should be all added now I believe |
XFactHD
approved these changes
Sep 17, 2024
sciwhiz12
approved these changes
Sep 17, 2024
|
Branch updated to match latest, should be ready to be merged if all reviews check out |
|
🚀 This PR has been released as NeoForge version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off the issue brought up in #1527 where it can get a bit messy accessing
RegistryAccessthroughServerLifecycleHookswhen most events should have easy access to itThis PR aims to fix this and passes
RegistryAccessthrough to 3 new events,VillagerTradesEvent,WandererTradesEventandRegisterBrewingRecipesEventat the moment through a new methodgetRegistryAccessin the eventAfter a discussion with @sciwhiz12, we mentioned leaving this PR open for 3 days, where upon other community members or contributors can mention other events that can or should have access. If there are any more events you want to see get it, let me know and I'll work on it!
(Also this is my first time doing patch changes, so if I've done something wrong, let me know)