-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add c:obsidians/normal
and c:obsidians/crying
subtags
#1556
Add c:obsidians/normal
and c:obsidians/crying
subtags
#1556
Conversation
Last commit published: 68b7cce3319f9f718bfab582756be12dcb902408. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1556' // https://github.com/neoforged/NeoForge/pull/1556
url 'https://prmaven.neoforged.net/NeoForge/pr1556'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1556
cd NeoForge-pr1556
curl -L https://prmaven.neoforged.net/NeoForge/pr1556/net/neoforged/neoforge/21.1.63-pr-1556-ObsidianSubtags/mdk-pr1556.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
Fabric PR updated with change: FabricMC/fabric#4088 |
src/main/java/net/neoforged/neoforge/common/data/internal/NeoForgeBlockTagsProvider.java
Outdated
Show resolved
Hide resolved
🚀 This PR has been released as NeoForge version |
This PR was a request from some users.
The original change to having Crying Obsidian in the
c:obsidians
tag was required as it is obsidian and excluding it would've been illogical and completely arbitrary. Much like saying brown mushroom shouldn't be in a mushroom tag because it is a light block despite a mushroom.However, adding subtags is more ideal for narrowing down and clarifying usages. In this case, recipes can target
c:obsidians/normal
and won't have to worry about other mod's special rare obsidians making it inside too. This is the same setup that we do forc:cobblestones/normal
,c:cobblestones/mossy
,c:cobblestones/infested
so we have precedence for using normal for the default regular block.Closes #1548