Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c:obsidians/normal and c:obsidians/crying subtags #1556

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

This PR was a request from some users.

The original change to having Crying Obsidian in the c:obsidians tag was required as it is obsidian and excluding it would've been illogical and completely arbitrary. Much like saying brown mushroom shouldn't be in a mushroom tag because it is a light block despite a mushroom.

However, adding subtags is more ideal for narrowing down and clarifying usages. In this case, recipes can target c:obsidians/normal and won't have to worry about other mod's special rare obsidians making it inside too. This is the same setup that we do for c:cobblestones/normal, c:cobblestones/mossy, c:cobblestones/infested so we have precedence for using normal for the default regular block.

Closes #1548

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.21.1 Targeted at Minecraft 1.21.1 awaiting community agreement labels Sep 20, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this Sep 20, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Sep 20, 2024

  • Publish PR to GitHub Packages

Last commit published: 68b7cce3319f9f718bfab582756be12dcb902408.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1556' // https://github.com/neoforged/NeoForge/pull/1556
        url 'https://prmaven.neoforged.net/NeoForge/pr1556'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1556.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1556
cd NeoForge-pr1556
curl -L https://prmaven.neoforged.net/NeoForge/pr1556/net/neoforged/neoforge/21.1.63-pr-1556-ObsidianSubtags/mdk-pr1556.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@TelepathicGrunt
Copy link
Contributor Author

Fabric PR updated with change: FabricMC/fabric#4088

@TelepathicGrunt TelepathicGrunt merged commit 762725e into neoforged:1.21.x Sep 23, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for "natural" Obsidian tag
2 participants