Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.4] Render local player when the renderViewEntity is not the local player #859

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

CreativeMD
Copy link
Contributor

@CreativeMD CreativeMD commented Apr 25, 2024

Hey there,
I noticed that NeoForge is missing the fix for not rendering the local player when a custom view entity has been set. The original fix can be found here: MinecraftForge/MinecraftForge#7216

This pr readds the fix. Backport from #859

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@Shadows-of-Fire Shadows-of-Fire added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.20.4 Targeted at Minecraft 1.20.4 labels Apr 26, 2024
@embeddedt embeddedt merged commit a6c0af5 into neoforged:1.20.4 Apr 30, 2024
4 checks passed
@CreativeMD CreativeMD deleted the 1.20.4_render_fix branch April 30, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.4 Targeted at Minecraft 1.20.4 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants