Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installer URLs without a trailing slash #159

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix installer URLs without a trailing slash #159

merged 2 commits into from
Apr 30, 2024
+7 −1

Conversation

Matyrobbrt
Copy link
Member

URI#resolve is stupid.

@Matyrobbrt Matyrobbrt added the bug Something isn't working label Apr 30, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Apr 30, 2024 •
edited
Loading

  • Publish PR to GitHub Packages

Last commit published: e8a1d7e30216b9bea1a31e5cec20b979acf3e042.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #159' // https://github.com/neoforged/NeoGradle/pull/159
        url 'https://prmaven.neoforged.net/NeoGradle/pr159'
        content {
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'utils')
        }
    }
}

@Matyrobbrt Matyrobbrt changed the title Fix installer URLs without a leading slash Fix installer URLs without a trailing slash Apr 30, 2024
@Matyrobbrt Matyrobbrt enabled auto-merge (squash) April 30, 2024 20:35
@marchermans marchermans enabled auto-merge (squash) April 30, 2024 20:40
@marchermans marchermans merged commit ee9d068 into neoforged:NG_7.0 Apr 30, 2024
26 checks passed
@Matyrobbrt Matyrobbrt deleted the fix-installer-urls-without-slash branch April 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchermans marchermans marchermans approved these changes

@shartte shartte shartte approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matyrobbrt @shartte @marchermans