-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport recent fixes to 5.7.5 release with Python 3.8 and later compatibility #340
Conversation
24a1fd4
to
7196548
Compare
One of the reported linter errors is present on the master branch too, fixed in #341. The others emerge after the changes in this PR, but AFAICT they are not related to the changes proposed here. |
@dnicolodi, I don't remember how we did this the last time. Merging to I can create a All tests should pass, even if it means patching them on the branch . |
I looked at the few warnings from |
Sure, I didn't want to propose to merge this into Creating a release branch would be the way forward. If there would be more tweaks required, we could have a Sure, all the test should pass before merging. |
With |
The PERF203 by You'll have to merge from upstream to update the pull request. |
Rebased on |
@dnicolodi I need to create a branch so you can target this pull request there, and it's done! The branch is Target the pull request there so there is no interference with |
I changed the target branch for the PR to |
Merged! Let me take a moment to think about the release process (I don't remember what I did the last time). |
Thanks @apalala ! I may be stating the obvious, but it looks like you can simply select the branch to tag when creating a new release. I don't think TatSu uses automation for building wheels, thus uploading to PyPI would also require checking out the tag, building sdisgt and wheel and upload them to PyPI. |
Sorry for the delay. I'll get onto this shortly. |
@apalala It would be nice to push a release with these fixes. Thank you! |
Similarly to what we did with the 5.7.4 release, I would like to backport the recent improvements and bug fixes in a release compatible with Python 3.8 and later. This PR contains the changes required on top of the current master branch to support Python 3.8 and later. It would be great if this could become a 5.7.5 release. @apalala What do you think?