Skip to content

Commit

Permalink
Make codespell happy (typos, exclude list)
Browse files Browse the repository at this point in the history
This commit fixes a couple typos, and also adds 'NotIn' to codespell's
exclude list.

For some reason, codespell recently started noticing these without any
workflow updates.

See e.g.:

* https://github.com/neondatabase/autoscaling/actions/runs/9223395913/job/25376518993?pr=944
* https://github.com/neondatabase/autoscaling/actions/runs/9218422507/job/25361935678?pr=936
  • Loading branch information
sharnoff committed May 24, 2024
1 parent 42719c3 commit 2fbba92
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ jobs:
- uses: codespell-project/actions-codespell@94259cd8be02ad2903ba34a22d9c13de21a74461 # v2.0
with:
check_hidden: true
ignore_words_list: NotIn # k8s match selectors; codespell tries to correct it to 'noting', 'not in', or 'notion'
skip: go.sum,./cluster-autoscaler/ca.patch

actionlint:
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ WORKDIR /workspace

ARG CA_GIT_TAG

# Download the repo. It's... quite large, but thankfuly this should get cached
# Download the repo. It's... quite large, but thankfully this should get cached
RUN git clone --depth=1 -b $CA_GIT_TAG https://github.com/kubernetes/autoscaler

# Only ADD the patch after downloading, to avoid wrecking the cache
Expand Down
2 changes: 1 addition & 1 deletion neonvm/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ status:
### Questions
- how generate name for target VM (name prefix/sufix/other) ?
- how generate name for target VM (name prefix/suffix/other) ?
- how long migration resource should be available (`kubectl get neonvmmigrate`) after migration finished ?
- how to cancel migration ? as variant - just delete it (`kubectl delete neonvmmigrate example`)
- should migration controller delete source VM after migration ?
Expand Down

0 comments on commit 2fbba92

Please sign in to comment.