Skip to content

Commit

Permalink
neonvm-controller: Remove unused auth proxy rbac (#1122)
Browse files Browse the repository at this point in the history
We used to run kube-auth-proxy as a sidecar alongside neonvm-controller.
That was removed in #825 — I guess the RBAC for it was forgotten.

This showed up because the v0.36.0 release YAMLs have a regression where
the RBAC for this unused proxy refers to 'system' and 'controller'
instead of 'neonvm-system' and 'neonvm-controller'.
  • Loading branch information
sharnoff authored Oct 23, 2024
1 parent 4192406 commit 3d54d14
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 87 deletions.
16 changes: 0 additions & 16 deletions neonvm/config/rbac/auth_proxy_client_clusterrole.yaml

This file was deleted.

24 changes: 0 additions & 24 deletions neonvm/config/rbac/auth_proxy_role.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions neonvm/config/rbac/auth_proxy_role_binding.yaml

This file was deleted.

21 changes: 0 additions & 21 deletions neonvm/config/rbac/auth_proxy_service.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions neonvm/config/rbac/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,3 @@ resources:
- virtualmachine_editor_role.yaml
- virtualmachinemigration_viewer_role.yaml
- virtualmachinemigration_editor_role.yaml
# Comment the following 4 lines if you want to disable
# the auth proxy (https://github.com/brancz/kube-rbac-proxy)
# which protects your /metrics endpoint.
- auth_proxy_service.yaml
- auth_proxy_role.yaml
- auth_proxy_role_binding.yaml
- auth_proxy_client_clusterrole.yaml

0 comments on commit 3d54d14

Please sign in to comment.