Skip to content

Commit

Permalink
neonvm-daemon: Use go-chef in Dockerfile (#1165)
Browse files Browse the repository at this point in the history
Probably an inadvertent merge conflict between #1090 and #989 meaning we
accidentally weren't using go-chef for neonvm-daemon.

Noticed this while working on #1163 locally and saw that it was
re-downloading all of the dependencies for neonvm-daemon every time,
even though I was making changes in the scheduler and the dependencies
hadn't changed.
  • Loading branch information
sharnoff authored Dec 4, 2024
1 parent d3e23a4 commit a0b1409
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ docker-build-runner: docker-build-go-base ## Build docker image for NeonVM runne
.

.PHONY: docker-build-daemon
docker-build-daemon: ## Build docker image for NeonVM daemon.
docker-build-daemon: docker-build-go-base ## Build docker image for NeonVM daemon.
docker build \
--tag $(IMG_DAEMON) \
--file neonvm-daemon/Dockerfile \
Expand Down
3 changes: 2 additions & 1 deletion neonvm-daemon/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM golang:1.23-alpine AS builder
ARG GO_BASE_IMG=autoscaling-go-base:dev
FROM $GO_BASE_IMG AS builder

# Build the Go binary
COPY . .
Expand Down

0 comments on commit a0b1409

Please sign in to comment.