Skip to content

Commit

Permalink
plugin: Fix HTTP 400s for old agents (#910)
Browse files Browse the repository at this point in the history
Another failure from #750, probably because the version slipped as the
PR was open for so long.

And... another thing that #580 could have caught.
  • Loading branch information
sharnoff authored Apr 16, 2024
1 parent 9c7f4f8 commit b8a54ec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/api/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,9 @@ func (v PluginProtoVersion) RepresentsMemoryAsBytes() bool {
// IncludesExtendedMetrics returns whether this version of the protocol includes the AgentRequest's
// metrics loadAvg5M and memoryUsageBytes.
//
// This is true for all versions below v4.0.
// This is true for all versions below v5.0.
func (v PluginProtoVersion) IncludesExtendedMetrics() bool {
return v < PluginProtoV4_0
return v < PluginProtoV5_0
}

// AgentRequest is the type of message sent from an autoscaler-agent to the scheduler plugin
Expand Down

0 comments on commit b8a54ec

Please sign in to comment.