Skip to content

Commit

Permalink
tmp: Ignore filter denial in method failure metrics
Browse files Browse the repository at this point in the history
  • Loading branch information
sharnoff committed Dec 13, 2024
1 parent 6c76e9d commit c7dee65
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/plugin/framework_methods.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ func (m frameworkMetrics) incMethodCall(method string, pod *corev1.Pod, ignored
}

func (m frameworkMetrics) incFailIfnotSuccess(method string, pod *corev1.Pod, ignored bool, status *framework.Status) {
if status.IsSuccess() {
// it's normal for Filter to return Unschedulable, because that's its way of filtering out pods.
if status.IsSuccess() || (method == "Filter" && status.Code() == framework.Unschedulable) {
return
}

Expand Down

0 comments on commit c7dee65

Please sign in to comment.