Override images in deploy/* before release

Bit of a hack, but that's ok for now. We can switch to properly using
kustomize as a separate PR.

.github/workflows/release.yaml

@@ -79,6 +79,13 @@ jobs:
           docker cp $ID:/usr/bin/vm-informant bin/vm-informant
           docker rm -f $ID
 
+      # note: We *could* use something like kustomize for this. But there's extra steps (e.g.,
+      # adding kustomization.yaml) and sed is simple; so we can deal with this for now.
+      - name: modify deploy files to use current image(s)
+        run: |
+          sed -i -e s^localhost:5001/autoscaler-agent:latest^${{ env.AGENT_IMAGE }}:${{ steps.get_vcs_info.outputs.version }} deploy/autoscale-scheduler.yaml
+          sed -i -e s^localhost:5001/kube-autoscale-scheduler:latest^${{ env.SCHED_IMAGE }}:${{ steps.get_vcs_info.outputs.version }} deploy/autoscaler-agent.yaml
+
       - name: github release
         uses: softprops/action-gh-release@v1
         with:

deploy/autoscale-scheduler.yaml

@@ -160,6 +160,8 @@ spec:
     spec:
       serviceAccountName: autoscale-scheduler
       containers:
+      # hey! This image name is hard-coded in .github/workflows/release.yaml - make sure to
+      # update that as well if you change this line!
       - image: localhost:5001/kube-autoscale-scheduler:latest
         command: ["/usr/bin/kube-scheduler", "--config=/etc/kubernetes/autoscale-scheduler-config/scheduler-config.yaml"]
         livenessProbe:

deploy/autoscaler-agent.yaml

@@ -91,6 +91,8 @@ spec:
       serviceAccountName: autoscaler-agent
       containers:
         - name: autoscaler-agent
+          # hey! This image name is hard-coded in .github/workflows/release.yaml - make sure to
+          # update that as well if you change this line!
           image: localhost:5001/autoscaler-agent:latest
           resources:
             limits: