Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish neonvm-daemon image as a part of the build-images.yml #1167

Closed
mikhail-sakhnov opened this issue Dec 5, 2024 · 0 comments · Fixed by #1168
Closed

Publish neonvm-daemon image as a part of the build-images.yml #1167

mikhail-sakhnov opened this issue Dec 5, 2024 · 0 comments · Fixed by #1168

Comments

@mikhail-sakhnov
Copy link
Contributor

mikhail-sakhnov commented Dec 5, 2024 •
edited
Loading

To use neonvm-daemon in the neon/neon build vm workflows, the image should be published to the registry.

Effectively that means add neonvm-daemon build step to the build-images.yml repo in the neon/autoscaling.

Blocks using the feature introduced with the #1111
@mikhail-sakhnov mikhail-sakhnov mentioned this issue Dec 5, 2024
Merged
sharnoff pushed a commit that referenced this issue Dec 6, 2024
@mikhail-sakhnov
ci: build neonvm-daemon in build-images.yaml (#1168)
3be61c4 
Build and publish neonvm-daemon images since they are expected to be
used by neondatabase/neon repository during the "build vm image" step. [1]

For the simplicity, the neondatabase/autoscaling repo keeps building
local version of the daemon image during the vm-example workflow
(cronbased job) and during the build-test-vm workflow (is used as an
external workflow in the e2e tests).

Closes #1167

[1]: https://github.com/neondatabase/neon/blob/14c4fae64af5613c682ec7dd7d30e484c476e5af/.github/workflows/build_and_test.yml#L820

---------

Signed-off-by: Misha Sakhnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: build neonvm-daemon in build-images.yaml neondatabase/autoscaling
1 participant
@mikhail-sakhnov