Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build neonvm-daemon in build-images.yaml #1168

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

mikhail-sakhnov
Copy link
Contributor

@mikhail-sakhnov mikhail-sakhnov commented Dec 5, 2024

Build and publish neonvm-daemon images since they are expected to be used by neondatabase/neon repository during the "build vm image" step.

For the simplicity, the neondatabase/autoscaling repo keeps building local version of the daemon image during the vm-example workflow (cronbased job) and during the build-test-vm workflow (is used as an external workflow in the e2e tests).

Closes #1167

@mikhail-sakhnov mikhail-sakhnov marked this pull request as ready for review December 5, 2024 12:38
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/publish-daemon-image branch from 786a465 to 74afb0d Compare December 5, 2024 16:03
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/publish-daemon-image branch from 74afb0d to 1977c04 Compare December 5, 2024 16:30
Copy link
Contributor

@Omrigan Omrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am not very experienced with CI configuration.

Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sharnoff sharnoff enabled auto-merge (squash) December 6, 2024 16:42
@sharnoff sharnoff merged commit 3be61c4 into main Dec 6, 2024
22 checks passed
@sharnoff sharnoff deleted the misha/publish-daemon-image branch December 6, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish neonvm-daemon image as a part of the build-images.yml
3 participants