Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer experience changes to make tooling work #1004

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Developer experience changes to make tooling work #1004

merged 3 commits into from
Jul 10, 2024

Conversation

Omrigan
Copy link
Contributor

@Omrigan Omrigan commented Jul 9, 2024

Bundled together to save time. To be merged as a rebase.

Part of the #921

@Omrigan Omrigan requested review from bayandin and sharnoff July 9, 2024 10:59
Omrigan added 2 commits July 9, 2024 15:05
@Omrigan
go.mod: fix dependency version
b5ba2a9 
Otherwise, the following fails:

~> go list -m all
go: github.com/optiopay/[email protected]: invalid version: unknown revision 000000000000

Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
lint: bump golangci-lint to v1.59.1 and fix new warnings
3b19cc5 
Signed-off-by: Oleg Vasilev <[email protected]>
sharnoff
sharnoff approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

For my own curiosity, do we know what causes the issue with github.com/optiopay/kafka?

@Omrigan
Copy link
Contributor Author

Omrigan commented Jul 10, 2024 •
edited
Loading

Nice, thanks!

For my own curiosity, do we know what causes the issue with github.com/optiopay/kafka?

The version mentioned in a cillum's go.mod is github.com/optiopay/[email protected]. I think, tooling by default expects the last part to be parsed as git revision.

@Omrigan Omrigan enabled auto-merge (rebase) July 10, 2024 10:15
@Omrigan Omrigan merged commit 2063bad into main Jul 10, 2024
15 checks passed
@Omrigan Omrigan deleted the oleg/devex branch July 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharnoff sharnoff sharnoff approved these changes

@bayandin bayandin Awaiting requested review from bayandin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omrigan @sharnoff