neonvm-controller: patch status if reconcile fails (#889) #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More I think about it - if requeue is still required for some reason - it's better to increase duration between runs to some reasonable period like 10-30 seconds. |
agadelshin
force-pushed
the
agadelshin/patch-status
branch
from
929d943 to
dda7cc2
Compare
|
Removed requeAfter changes because it's already a part of #1016 |
agadelshin
force-pushed
the
agadelshin/patch-status
branch
from
dda7cc2 to
3bf2d00
Compare
This was referenced Oct 10, 2024
|
Closed in favor of #1102 and #1103. @agadelshin Thank you for the proactive proposal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added status update on fail. There is a way to just run it in a defer, but it's only 2 places so I guess it's more straightforward solution.
Also changed Update to Patch, added request of virtualmachine before to avoid conflicts.
And a last one - removed requeue after succesful reconcile, it's not required to reconcile if nothing happens, reconcile will be queued if there will be a change in a VirtualMachine or Pod with VirtualMachine owner. If there is another reason to keep it in a constant loop - please tell, will update it. Otherwise it'll save some CPU cycles and make logs more readable.
Tested it manually on a virtualmachine inside GCP, if there is a way to run autoscaling on Silicon Apple, I'd be happy to know (x86-64 emulation in QEMU is too slow, took hours to build everything).