neonvm: Add controller flag to disable runner cgroup #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds new flags to neonvm-controller and neonvm-runner: * controller: -disable-runner-cgroup * runner: -enable-dummy-cpu-server If the controller is passed -disable-runner-cgroup, then it will pass both -skip-cgroup-management and -enable-dummy-cpu-server to new runner pods. If neonvm-runner is passed -enable-dummy-cpu-server (requires the -skip-cgroup-management flag), it will *not* run QEMU in a cgroup, but still provide an HTTP server with endpoints that pretend as if the CPU limit was updated successfully. Internally, the runner's "dummy" implementation still needs to store the most recently set value to provide it back to the controller, so that it doesn't infinitely loop trying to set the CPU. ref https://neondb.slack.com/archives/C06SJG60FRB/p1723485730034399
Omrigan
approved these changes
Aug 22, 2024
| @@ -620,7 +624,10 @@ func newConfig(logger *zap.Logger) *Config { | |||
| cfg.appendKernelCmdline, "Additional kernel command line arguments") | |||
| flag.BoolVar(&cfg.skipCgroupManagement, "skip-cgroup-management", | |||
| cfg.skipCgroupManagement, | |||
| "Don't try to manage CPU (use if running alongside container-mgr)") | |||
| "Don't try to manage CPU (use if running alongside container-mgr, or if dummy CPU server is enabled)") | |||
| flag.BoolVar(&cfg.enableDummyCPUServer, "enable-dummy-cpu-server", | |||
There was a problem hiding this comment.
Do we actually plan to use runner without the enable-dummy-cpu-server?
I don't mind that it is there, but I think I'd run the server unconditionally, until we (likely) decide to abandon it overall.
There was a problem hiding this comment.
Do we actually plan to use runner without the enable-dummy-cpu-server?
For now, yes. We haven't come to a decision beyond that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new flags to neonvm-controller and neonvm-runner:
-disable-runner-cgroup-enable-dummy-cpu-serverIf the controller is passed
-disable-runner-cgroup, then it will pass both-skip-cgroup-managementand-enable-dummy-cpu-serverto new runner pods.If neonvm-runner is passed
-enable-dummy-cpu-server(requires the-skip-cgroup-managementflag), it will not run QEMU in a cgroup, but still provide an HTTP server with endpoints that pretend as if the CPU limit was updated successfully.Internally, the runner's "dummy" implementation still needs to store the most recently set value to provide it back to the controller, so that it doesn't infinitely loop trying to set the CPU.
ref https://neondb.slack.com/archives/C06SJG60FRB/p1723485730034399