Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vxlan-controller: support dualstack #1057

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

chaporgin
Copy link
Member

In Azure we need to run Dualstack AKS at some point because that is the way to provision a dualstack NLB for AKS. There is no "bring your NLB" for AKS right now.

This skips ipv6 addresses during initialization, because autoscaler does not need ipv6, and the following lines do not work with ipv6 resulting in an error.

https://github.com/neondatabase/cloud/issues/13924

…he way to provision a dualstack NLB for AKS. There is no "bring your NLB" for AKS right now.

This skips ipv6 addresses during initialization, because autoscaler does not need ipv6, and the following lines do not work with ipv6 resulting in an error.
@chaporgin chaporgin requested a review from cicdteam August 30, 2024 13:26
@chaporgin chaporgin marked this pull request as ready for review August 30, 2024 13:26
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @cicdteam knows much more about this than I do.

Before merging, could you rename the PR title to start with "vxlan-controller: " to match other PRs?

@chaporgin chaporgin changed the title [vxlancontroller/azure] impr: support dualstack vxlan-controller: support dualstack Oct 7, 2024
@chaporgin chaporgin enabled auto-merge (squash) October 7, 2024 07:59
Copy link

github-actions bot commented Oct 7, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/neondatabase/autoscaling/neonvm/tools/vxlan/controller 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/neondatabase/autoscaling/neonvm/tools/vxlan/controller/main.go 0.00% (ø) 134 (+3) 0 134 (+3)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

HTML Report

Click to open

@chaporgin chaporgin merged commit 72267ba into main Oct 7, 2024
22 checks passed
@chaporgin chaporgin deleted the chapson/13924-ipv6-support-for-aks branch October 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants