agent: Remove unused "error" exit status #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tasks associated with a VM *originally* could exit with an error on startup, and we'd retry after a duration. This hasn't been possible for some time, so we're better off removing the machinery for it. Note: This PR removes the following metric: - autoscaling_agent_runner_fatal_errors_total
Omrigan
approved these changes
Sep 19, 2024
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. HTML Report |
|
AFAICT, removed the metric from all relevant places. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tasks associated with a VM originally could exit with an error on startup, and we'd retry after a duration. This hasn't been possible for some time, so we're better off removing the machinery for it.
Note: This PR removes the following metric:
autoscaling_agent_runner_fatal_errors_totalNotes for review: Given the metric is currently always zero, we should preemptively remove it from dashboards & alerts before merging.
Also worth noting this came up as part of neondatabase/docs#96.