agent,billing: Move clients and queue into new pkg/reporting
#1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharnoff
force-pushed
the
sharnoff/scaling-event-reporting-1
branch
from
9bb7768 to
c0ad93e
Compare
Omrigan
reviewed
Oct 10, 2024
| @@ -1,21 +1,10 @@ | |||
| package billing | |||
There was a problem hiding this comment.
Does it make sense to get rid of this package and move all the stuff to either agent/billing or reporting?
There was a problem hiding this comment.
I'd like to do that, yeah. Wanted to leave it outside the scope of this change for now though — will keep this comment open as a reminder.
sharnoff
added a commit
that referenced
this pull request
Oct 12, 2024
This is part 2 of 2; see #1078 for the ground work. In short, this commit: * Adds a new package: 'pkg/agent/scalingevents' * Adds new callbacks to core.State to allow it to report on scaling events changes in desired CU.
sharnoff
added a commit
that referenced
this pull request
Oct 12, 2024
This is part 2 of 2; see #1078 for the ground work. In short, this commit: * Adds a new package: 'pkg/agent/scalingevents' * Adds new callbacks to core.State to allow it to report on scaling events changes in desired CU.
sharnoff
force-pushed
the
sharnoff/scaling-event-reporting-1
branch
2 times, most recently
from
f608569 to
1c71a57
Compare
sharnoff
added a commit
that referenced
this pull request
Oct 12, 2024
This is part 2 of 2; see #1078 for the ground work. In short, this commit: * Adds a new package: 'pkg/agent/scalingevents' * Adds new callbacks to core.State to allow it to report on scaling events changes in desired CU.
|
@Omrigan I've responded to review comments. LMK what you think. |
This commit adds a new package: pkg/reporting. The new package contains both the HTTP/S3/Azure Blob client implementations from pkg/billing, as well as the event queue and sender implementation from pkg/agent/billing. The intent is to provide a 'plug and play' infrastructure for asynchronously sending billing events (among other event types) to a variety of sources, with the code responsible for generating those events only being responsible for setting up the clients and queueing the events.
sharnoff
force-pushed
the
sharnoff/scaling-event-reporting-1
branch
from
a46466d to
df54b37
Compare
sharnoff
added a commit
that referenced
this pull request
Oct 17, 2024
This is part 2 of 2; see #1078 for the ground work. In short, this commit: * Adds a new package: 'pkg/agent/scalingevents' * Adds new callbacks to core.State to allow it to report on scaling events changes in desired CU.
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
HTML Report |
sharnoff
added a commit
that referenced
this pull request
Nov 18, 2024
This is part 2 of 2; see #1078 for the ground work. In short, this commit: * Adds a new package: 'pkg/agent/scalingevents' * Adds new callbacks to core.State to allow it to report on scaling events changes in desired CU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial refactoring for neondatabase/cloud#15939 — opening this PR early because it's rather substantial and might be good discuss earlier on.
Details of this change
This commit adds a new package:
pkg/reporting.The new package contains both the HTTP/S3/Azure Blob client implementations from
pkg/billing, as well as the event queue and sender implementation frompkg/agent/billing.The intent is to provide a 'plug and play' infrastructure for asynchronously sending billing events (among other event types) to a variety of sources, with the code responsible for generating those events only being responsible for setting up the clients and queueing the events.
Current state: All should be working as expected.
Notes for review: It's a big diff, sorry. I'm not totally sure if there's good ways to make it come out cleaner. Open for feedback on the new design — looking at
pkg/reportingdirectly (particularlyclient.goandsink.go) is probably also the easiest way to get your bearings on the change as a whole.