Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-autoscaler: Upgrade to 1.28.6 #1097

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Conversation

SergeyMelnikov
Copy link
Contributor

@SergeyMelnikov SergeyMelnikov commented Oct 8, 2024

PR is not ready yet, there are conflicts in the patch

@SergeyMelnikov SergeyMelnikov force-pushed the sergey/cluster-autoscaler-1.28 branch from 16ca192 to 1e0b372 Compare October 8, 2024 13:45
@SergeyMelnikov SergeyMelnikov marked this pull request as draft October 8, 2024 13:48
@chaporgin chaporgin changed the title Upgrade cluster-autoscaler to latest 1.28 [cluster-autoscaler/patch] impr: Upgrade cluster-autoscaler to latest 1.28 Oct 10, 2024
@chaporgin chaporgin changed the title [cluster-autoscaler/patch] impr: Upgrade cluster-autoscaler to latest 1.28 cluster-autoscaler/patch: Upgrade cluster-autoscaler to latest 1.28 Oct 10, 2024
@chaporgin chaporgin marked this pull request as ready for review October 15, 2024 09:13
@chaporgin
Copy link
Member

The conflicts were resolved.

@chaporgin chaporgin changed the title cluster-autoscaler/patch: Upgrade cluster-autoscaler to latest 1.28 cluster-autoscaler/patch: Upgrade cluster-autoscaler to 1.28.6 Oct 15, 2024
@edude03 edude03 requested review from sharnoff and bayandin October 31, 2024 20:16
@edude03
Copy link
Contributor

edude03 commented Oct 31, 2024

Guess I'm taking this PR over so I won't review it, It seems to work, I deployed 26 nginx pods with node anti affinity and extra nodes were created.

@bayandin bayandin removed their request for review November 1, 2024 13:33
@sharnoff sharnoff self-assigned this Nov 1, 2024
@edude03 edude03 force-pushed the sergey/cluster-autoscaler-1.28 branch from 0b8e242 to b5007c0 Compare November 1, 2024 19:11
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this everyone :)

@sharnoff sharnoff changed the title cluster-autoscaler/patch: Upgrade cluster-autoscaler to 1.28.6 cluster-autoscaler: Upgrade to 1.28.6 Nov 5, 2024
@edude03 edude03 merged commit 26d39a6 into main Nov 5, 2024
24 checks passed
@edude03 edude03 deleted the sergey/cluster-autoscaler-1.28 branch November 5, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants