Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/vm-kernel: Fix outdated comments #1101

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/vm-kernel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ jobs:
- name: get kernel version
id: get-kernel-version
run: |
linux_config=$(ls neonvm-kernel/linux-config-*) # returns something like "neonvm-kernel/linux-config-6.1.63"
kernel_version=${linux_config##*-} # returns something like "6.1.63"
linux_config=$(ls neonvm-kernel/linux-config-*) # returns something like "neonvm-kernel/linux-config-amd64-6.1.63"
kernel_version=${linux_config##*-} # returns something like "amd64-6.1.63"

echo VM_KERNEL_VERSION=$kernel_version >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -194,7 +194,7 @@ jobs:
build-args: KERNEL_VERSION=${{ steps.get-kernel-version.outputs.VM_KERNEL_VERSION }}
context: neonvm-kernel
platforms: linux/amd64
# neonvm/hack/kernel/Dockerfile.kernel-builder has different targets for different architectures
# neonvm-kernel/Dockerfile.kernel-builder has different targets for different architectures
# so we need to specify the target explicitly
target: kernel_amd64
# Push kernel image only for scheduled builds or if workflow_dispatch/workflow_call input is true
Expand Down
Loading