ci/vm-kernel: change CACHE_TAG calculation #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayandin
force-pushed
the
bayandin/use-hashFiles-instead-of-git-sha
branch
from
fc3203a to
71553c7
Compare
bayandin
changed the title
bayandin
force-pushed
the
bayandin/use-hashFiles-instead-of-git-sha
branch
from
71553c7 to
f70c946
Compare
fedordikarev
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PRs, it is incorrect to use the last commit sha as a cache tag for a docker kernel image.
By default, on
pull_request,actions/checkoutpulls a fake merge commit (PR into the default branch), and potentially an outdated kernel image from the cache might be used in a PR (ifmainhas some changes in the kernel, and PR doesn't include it yet).This PR changes the logic from using the last commit sha to using a hash from
neonvm-kerneldirectory content and the workflow file itself.