neonvm-controller: Use virtio-mem when status.memoryProvider is nil #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #1060. Before we stop setting status.memoryProvider, we need to make sure that an empty status.memoryProvider is interpreted as virtio-mem. We *could* do that everywhere status.memoryProvider is used, but it's probably just easier to do it at top, replacing our handling that originally set DIMM slots by default.
mikhail-sakhnov
approved these changes
Oct 14, 2024
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. HTML Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1060. Before we stop setting
status.memoryProvider, we need to make sure that an emptystatus.memoryProvideris interpreted as virtio-mem.We could do that everywhere
status.memoryProvideris used, but it's probably just easier to do it at top, replacing our handling that originally set DIMM slots by default.