Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonvm-builder: arm images #1116

Merged
merged 5 commits into from
Dec 10, 2024
Merged

neonvm-builder: arm images #1116

merged 5 commits into from
Dec 10, 2024

Conversation

mikhail-sakhnov
Copy link
Contributor

@mikhail-sakhnov mikhail-sakhnov commented Oct 17, 2024

Modify neonvm-builder to support building images with both amd64 or arm64 architectures.
Change busybox loader to use public image busybox:1.35.0-musl instead of downloading busybox from busybox.net
Parametrize vector url to be architecture specific.
Has no cross-build support, produced image architecture is the same as host machine architecture.

#1081

Copy link

github-actions bot commented Oct 17, 2024

No changes to the coverage.

HTML Report

Click to open

@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch 2 times, most recently from 6e5748f to 3e86f49 Compare October 17, 2024 12:26
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/cpu-scaling branch 3 times, most recently from 5a094ae to 82a4827 Compare October 17, 2024 12:45
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from 3e86f49 to 83795fd Compare October 17, 2024 12:45
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/cpu-scaling branch 3 times, most recently from 636e001 to 51a46df Compare October 21, 2024 10:17
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from ca01120 to edad3c8 Compare October 21, 2024 10:52
@mikhail-sakhnov mikhail-sakhnov changed the title WIP: Misha/builder arm support vm-builder: arm images Oct 21, 2024
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch 2 times, most recently from f57a2f5 to f55efed Compare October 21, 2024 11:07
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch 6 times, most recently from 53d1f78 to 956d57f Compare October 21, 2024 12:31
@mikhail-sakhnov mikhail-sakhnov marked this pull request as ready for review October 21, 2024 12:42
@mikhail-sakhnov mikhail-sakhnov requested review from Omrigan, bayandin and sharnoff and removed request for bayandin October 21, 2024 12:42
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good. Left some comments, nothing major.

.github/workflows/vm-example.yaml Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
vm-builder/main.go Show resolved Hide resolved
vm-builder/main.go Outdated Show resolved Hide resolved
vm-builder/main.go Outdated Show resolved Hide resolved
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Given that #1111 is broader than just ARM, let's keep this PR separate until that's merged?

@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from 629281d to 6fb99e4 Compare October 31, 2024 02:14
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/cpu-scaling branch 5 times, most recently from ffd9538 to 27299cb Compare November 19, 2024 06:36
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/cpu-scaling branch 4 times, most recently from fe10eef to 79721a2 Compare November 26, 2024 12:14
Base automatically changed from misha/cpu-scaling to main November 27, 2024 14:52
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch 5 times, most recently from c63ada8 to f4dce7b Compare December 4, 2024 14:06
@mikhail-sakhnov mikhail-sakhnov changed the title vm-builder: arm images neonvm-builder: arm images Dec 4, 2024
@Omrigan Omrigan changed the title neonvm-builder: arm images vm-builder: arm images Dec 6, 2024
Copy link
Contributor

@Omrigan Omrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one comment.

One more thing is that it would be helpful to either enumerate the changes in a commit message (generic busybox, generic kuttl, custom init line and parateers propagations), or, have them as separate commit after merge.

vm-builder/main.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mikhail-sakhnov mikhail-sakhnov changed the title vm-builder: arm images neonvm-builder: arm images Dec 10, 2024
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/builder-arm-support branch from a2d3587 to 5bee7bc Compare December 10, 2024 08:01
@mikhail-sakhnov mikhail-sakhnov merged commit 5b1fb31 into main Dec 10, 2024
24 checks passed
@mikhail-sakhnov mikhail-sakhnov deleted the misha/builder-arm-support branch December 10, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants