-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neonvm-builder: arm images #1116
Conversation
No changes to the coverage.
HTML Report |
6156c36
to
f63fdc9
Compare
6e5748f
to
3e86f49
Compare
5a094ae
to
82a4827
Compare
3e86f49
to
83795fd
Compare
636e001
to
51a46df
Compare
ca01120
to
edad3c8
Compare
f57a2f5
to
f55efed
Compare
51a46df
to
e360666
Compare
53d1f78
to
956d57f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly looks good. Left some comments, nothing major.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Given that #1111 is broader than just ARM, let's keep this PR separate until that's merged?
08b6b6a
to
991ba87
Compare
629281d
to
6fb99e4
Compare
ffd9538
to
27299cb
Compare
fe10eef
to
79721a2
Compare
c63ada8
to
f4dce7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for one comment.
One more thing is that it would be helpful to either enumerate the changes in a commit message (generic busybox, generic kuttl, custom init line and parateers propagations), or, have them as separate commit after merge.
Add arm support to vm-builder without cross-compilation
Signed-off-by: Misha Sakhnov <[email protected]>
Rollback kuttl version Simplify agetty init line passing
a2d3587
to
5bee7bc
Compare
Modify neonvm-builder to support building images with both amd64 or arm64 architectures.
Change busybox loader to use public image busybox:1.35.0-musl instead of downloading busybox from busybox.net
Parametrize vector url to be architecture specific.
Has no cross-build support, produced image architecture is the same as host machine architecture.
#1081