Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build arm images in CI #1126

Conversation

mikhail-sakhnov
Copy link
Contributor

@mikhail-sakhnov mikhail-sakhnov commented Oct 28, 2024

Introduce builds for vm-images, component images and kernel for both amd64 and arm64 architectures.
E2E tests run only for amd64, they are intentionally left out.

#1089

…xplicitly default the field value if it is not set

Signed-off-by: Misha Sakhnov <[email protected]>
…nd mark vmSpec.Guest.CPUs.Min as online during the boot

Signed-off-by: Misha Sakhnov <[email protected]>
introduce separate CPU scaling flow based on the vmSpec.cpuScalingMode

If vmSpec.cpuScalingMode is equal to `qmp_scaling` the logic of the
scaling is preserved as before:

- Scale, if required the amount of CPUs using qmp commands.
- If it is required to scale cgroups, call vm-runner /cpu_change endpoint

if vmSpec.cpuScalingMode is equal to `cpuSysfsStateScaling` all cpu
scaling requests go directly to the vm-runner /cpu_change, which in
that configuration goes to the neonvm-daemon to reconcile required
amount of online CPUs.

Value `cpuSysfsStateScaling` also modifies the qemu and the kernel
arguments to enable plug all CPUs but mark as online only first one.

Signed-off-by: Misha Sakhnov <[email protected]>
pass cpuScalingMode as argument to the vm-runner
rename arguments, constants and functions here and there
drop unused code
move default cpu scaling mode to controller argument

Signed-off-by: Misha Sakhnov <[email protected]>
Add arm support to vm-builder without cross-compilation
Copy link

github-actions bot commented Oct 28, 2024

No changes to the coverage.

HTML Report

Click to open

@mikhail-sakhnov mikhail-sakhnov changed the title DRAFT, WIP: support arm CI ci: support arm CI [draft, wip] Oct 28, 2024
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/WIP-ci-for-arm branch 13 times, most recently from 0e645bc to 3372e65 Compare October 29, 2024 12:05
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/WIP-ci-for-arm branch 7 times, most recently from b3692fd to d9436d2 Compare October 30, 2024 12:34
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/WIP-ci-for-arm branch 4 times, most recently from c282c5e to da49b82 Compare October 30, 2024 20:44
@mikhail-sakhnov mikhail-sakhnov changed the base branch from main to misha/network-settings-for-local-arm October 30, 2024 22:36
@mikhail-sakhnov mikhail-sakhnov changed the base branch from misha/network-settings-for-local-arm to misha/runner-arm-support October 30, 2024 22:37
@mikhail-sakhnov mikhail-sakhnov changed the base branch from misha/runner-arm-support to misha/builder-arm-support October 30, 2024 23:09
@mikhail-sakhnov mikhail-sakhnov changed the base branch from misha/builder-arm-support to misha/network-settings-for-local-arm October 30, 2024 23:13
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/network-settings-for-local-arm branch 2 times, most recently from b13ee03 to 2bbdeb6 Compare October 30, 2024 23:27
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/WIP-ci-for-arm branch 2 times, most recently from c2deb83 to 2628e06 Compare October 30, 2024 23:33
@mikhail-sakhnov mikhail-sakhnov changed the title ci: support arm CI [draft, wip] ci: build arm images in CI Oct 31, 2024
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/network-settings-for-local-arm branch from 2bbdeb6 to 67fec8e Compare October 31, 2024 00:56
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/network-settings-for-local-arm branch from 67fec8e to ae84971 Compare October 31, 2024 02:14
@mikhail-sakhnov mikhail-sakhnov force-pushed the misha/WIP-ci-for-arm branch 2 times, most recently from 6878b5b to b872793 Compare October 31, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant