-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent/goalcu: implement ZoneLoadAverage #1148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
Omrigan
changed the title
Implement ZoneLoadAverage
agent/goalcu: implement ZoneLoadAverage
Nov 18, 2024
Signed-off-by: Oleg Vasilev <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
Omrigan
force-pushed
the
oleg/zone-la
branch
from
November 20, 2024 15:38
d436c3d
to
5c915ba
Compare
Signed-off-by: Oleg Vasilev <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
sharnoff
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, awesome work on this 🚀
Left a few small comments; feel free to merge once addressed.
Co-authored-by: Em Sharnoff <[email protected]>
Signed-off-by: Oleg Vasilev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZoneLoadAverage compares abs(load1 - load5) against two thresholds, to determine if compute is in one of 3 zones:
The thresholds are computed as a percentage of a load5, the percentage is set by two new values:
cpuStableZoneRatio
andcpuMixedZoneRatio
.For example, for the
cpuStableZoneRatio = 0.25
,cpuMixedZoneRatio = 0.25
andload5 = 8
, we'd get:abs(load5 - load1) < 2
<=>6 < load1 < 10
2 < abs(load5 - load1) < 4
<=>4 < load1 < 6
or10 < load1 < 12
.Similar algorithm is described in https://www.notion.so/neondatabase/RFC-SwitchLoadAverage-13ef189e0047804f9297e8772739508e?pvs=4
Fixes #729