-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neonvm-kernel: kernel build improvements #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
6d257c5
to
5528d42
Compare
Closes #1154? |
@@ -26,18 +26,19 @@ with the following sequence of actions: | |||
``` | |||
2. Then, inside the container, run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should it be explained in this section that you need to do upgrade twice: once for x86, and once for arm64?
- Would it be possible to do this:
export KERNEL_ARCH=...
export OLD_VERSION=...
export NEW_VERSION-...
in the first step, and then pass the variables to docker run
with --env
, and overall make it so the remaining commands don't need to be modified?
446ea72
to
5ec2586
Compare
@Omrigan UPD: it actually does, I originally looked into separate kernel issue, my fault. |
cp /host/linux-config-$ARCH-$OLD_VERSION .config # Copy current config in | ||
make ARCH=$KERNEL_ARCH menuconfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these environment variables are defined on the host, are they actually available inside the container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I passed them as a build-arg 🤦 Moved to the docker run -e
Signed-off-by: Misha Sakhnov <[email protected]>
5ec2586
to
98f5e0b
Compare
Closing the PR because I accidentally rebased and pushed version from the other dev machine, and now some changes were losh 🤷 . Will re-open from the correct branch during normal working hours. |
Fix readme file for kernel builder
Update ubuntu to LTS
Rename kernel config file