Bump k8s dependencies to 1.30

[edude03]

Continuing the epic to upgrade from kubernetes 1.28 -> 1.31, bump the k8s dependencies

[github-actions]

No changes to the coverage.

HTML Report

Click to open

[sharnoff]

bump the dependencies for the neonvm components

For clarity, changing the dependencies version in go.mod updates all components except cluster-autoscaler. The biggest ones are neonvm-controller, scheduler, and autoscaler-agent.

Please also update the relevant k8s tool versions defined in the Makefile — see KUSTOMIZE_VERSION, ENVTEST_K8S_VERSION, CONTROLLER_TOOLS_VERSION, CODE_GENERATOR_VERSION, KUTTL_VERSION, KUBECTL_VERSION, KIND_VERSION, K3D_VERSION

(sorry!)

[edude03]

For clarity, changing the dependencies version in go.mod updates all components except cluster-autoscaler. The biggest ones are neonvm-controller, scheduler, and autoscaler-agent.

Is there a name/alias for that or should I mention them all?

Please also update the relevant k8s tool versions defined in the Makefile — see KUSTOMIZE_VERSION, ENVTEST_K8S_VERSION, CONTROLLER_TOOLS_VERSION, CODE_GENERATOR_VERSION, KUTTL_VERSION, KUBECTL_VERSION, KIND_VERSION, K3D_VERSION

(sorry!)

Don't be, thanks for the list. How do we pick what version each tool should be? For envtest and the node version in kind/k3d it should match kubernetes clearly, but everything else, seems like we have a mix?

Personally, I'd say we should do something like this:

1. Define TARGET_KUBE_VERSION

For the things that rely on a specific kube version, use that variable - either via interpolation OR for things that have a version right now, something like KUBECTL_VERSION=${KUBECTL_VERSION:-$TARGET_KUBE_VERSION}

2. Define a list of things that can be updated to the latest working version IE: (I believe) kuttl/k3d/kind should work at their latest versions.

3. Maybe a list of things and were the version comes from? I think we kind of have this now, with links to github releases, but maybe some things need links to the go.mod file for example.

[sharnoff]

Is there a name/alias for that or should I mention them all?

I would just name the PR something like "Bump k8s dependencies to 1.30". The PR title format checker will complain, but you can add <!-- affects all --> to the PR description to get it to go along with it :)

[sharnoff]

Lots of small comments. Assuming all's well, should just be one (shorter) round of review after this.

[sharnoff]

Can you elaborate on why it should match the k8s minor version?

(also: typo: s/kubeernetes/kubernetes/ 😄)

[edude03]

I actually don't know why it should match, though IIRC it was because of dep resolution errors

[sharnoff]

Hm, if we're not sure, then let's not add this comment?

[sharnoff]

Also, PR description still says

bump the dependencies for the neonvm components

[sharnoff]

One comment thread left, otherwise LGTM!