Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Fix comment in NamespacedName formatter #1164

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

sharnoff
Copy link
Member

@sharnoff sharnoff commented Dec 3, 2024

It wasn't correct; the separator is /, not :.

(I think once upon a time, we used to format it with :, but that's no longer the case).

Noticed this as part of #1163.

It wasn't correct; the separator is '/', not ':'.
Copy link

github-actions bot commented Dec 3, 2024

No changes to the coverage.

HTML Report

Click to open

@sharnoff sharnoff requested review from a team and Omrigan and removed request for a team December 3, 2024 15:01
@sharnoff sharnoff enabled auto-merge (squash) December 9, 2024 18:09
@sharnoff sharnoff merged commit 9299d53 into main Dec 9, 2024
22 checks passed
@sharnoff sharnoff deleted the sharnoff/util-fix-comment branch December 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants