Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neonvm-kernel: Switch to version 6.6.63 #1170

Closed
wants to merge 1 commit into from

Conversation

petuhovskiy
Copy link
Member

This commit updates the kernel and switches from 6.1.x to 6.6.x LTS branch.

As of 2024-12-06, www.kernel.org says this is the most recent version of the 6.6.x LTS branch.

Basically just followed the instructions in neonvm-kernel/README.md, copying in linux-config-ARCH-6.6.63 as .config, and .config back to /host once done with menuconfig. Fixed the instruction for amd64/arm64 along the way.

Trying this as a possible solution to https://github.com/neondatabase/cloud/issues/20195

Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair enough, but I'll leave it to Misha to give a more proper review.

One question, one request.

Question: What's the thinking between upgrading to latest 6.1.x vs 6.6.x ?

Request: Due to changes in upgrade instructions — if you haven't already, could you double-check that going through the upgrade steps for the current version produces an empty diff? (and if not, let's separate that into its own PR?)

I ask in part because there may be some changes due to #1159, and if there's a bunch it'd be good to isolate those out so they can be ignored.

```

Afterwards, it's probably also good to do a search-and-replace repo-wide to update all places that
mention the old kernel version.

### On arm64 (aarch64 ARM)

Note: you need to run this on ARM64 machine. It worked on my MacBook M2, but didn't on x64.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird... @mikhail-sakhnov any ideas what's needed to avoid this?

(broader context: I think it's risky to have kernel upgrade steps that depend on dev access to particular hardware, because it makes updating quite complex).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharnoff I answered in the pr #1172, should be doable cross platform

@petuhovskiy
Copy link
Member Author

Question: What's the thinking between upgrading to latest 6.1.x vs 6.6.x ?

Not much, just noticed that on kernel bugzilla it was a common suggestion to switch major version in similar cases:

@sharnoff
Copy link
Member

sharnoff commented Dec 6, 2024

just noticed that on kernel bugzilla it was a common suggestion to switch major version in similar cases

fair enough, makes sense!

@petuhovskiy
Copy link
Member Author

Request: Due to changes in upgrade instructions — if you haven't already, could you double-check that going through the upgrade steps for the current version produces an empty diff? (and if not, let's separate that into its own PR?)

I've splitted this into #1172. There is some diff for arm config, let's go there for discussion.

@petuhovskiy petuhovskiy marked this pull request as draft December 9, 2024 09:43
@petuhovskiy
Copy link
Member Author

There is a new kernel version, so I opened a new PR to upgrade to 6.6.64
=> #1174

@petuhovskiy petuhovskiy closed this Dec 9, 2024
petuhovskiy added a commit that referenced this pull request Dec 9, 2024
Fix the instruction for kernel upgrades, add separate commands for arm64
and amd64 config upgrades.

Rerun the commands with current version. It has produced some diff, most
likely due to ubuntu upgrade in
#1159.

Split off from #1170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants