Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent/billing: reset metrics right before setting it #1173

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

Omrigan
Copy link
Contributor

@Omrigan Omrigan commented Dec 9, 2024

Right now we sometimes see gaps in metrics, which can be explained by too much time between Reset() and the next Set().

See example: https://neondb.slack.com/archives/C03TN5G758R/p1731596259801509

Right now we sometimes see gaps in metrics, which can be explained by
too much time between Reset() and the next Set().

See example: https://neondb.slack.com/archives/C03TN5G758R/p1731596259801509

Signed-off-by: Oleg Vasilev <[email protected]>
Co-authored-by: Em Sharnoff <[email protected]>
@Omrigan Omrigan requested a review from sharnoff December 9, 2024 12:15
Copy link

github-actions bot commented Dec 9, 2024

No changes to the coverage.

HTML Report

Click to open

Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@Omrigan Omrigan enabled auto-merge (rebase) December 9, 2024 18:02
@Omrigan Omrigan merged commit 69163e9 into main Dec 10, 2024
22 checks passed
@Omrigan Omrigan deleted the oleg/metrics-reset branch December 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants