agent: Remove vm-informant support #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a comment
Without this, we'd (a) block on connecting to to the vm-monitor when starting up the Runner, and (b) take down all of the other Runner threads if we hit a fatal issue with the vm-monitor.
![arnica-github-connector[bot]](https://avatars.githubusercontent.com/in/144692?s=60&v=4){kind=small}
sharnoff
changed the title
sharnoff
added a commit
that referenced
this pull request
Oct 9, 2023
Introduced by #506, noticed after deploying v0.18.0 on staging. Basically, we just never set the start time, so "time since last start" was always equal to "time since unix epoch", which means we'd always think that the connection was running long enough to immediately retry.
sharnoff
added a commit
that referenced
this pull request
Oct 9, 2023
Introduced by #506, noticed after deploying v0.18.0 on staging. Basically, we just never set the start time, so "time since last start" was always equal to "time since unix epoch", which means we'd always think that the connection was running long enough to immediately retry.
This was referenced Oct 12, 2023
sharnoff
added a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all informant related code from the runner. The only thing left to do is rename the metrics.