Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "speculative workaround for high unclosed connection count between compute smgr & pageserver" #524

Closed
wants to merge 1 commit into from
Closed

Revert "speculative workaround for high unclosed connection count between compute smgr & pageserver" #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions neonvm/tools/vm-builder/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,13 +260,6 @@ action=/neonvm/bin/powerdown
scriptPowerDown = `#!/neonvm/bin/sh

su -p postgres --session-command '/usr/local/bin/pg_ctl stop -D /var/db/postgres/compute/pgdata -m fast --wait -t 10'
# The poweroff below is the busybox poweroff which goes straight to the kernel, i.e., LINUX_REBOOT_CMD_POWER_OFF / RB_POWER_OFF.
# Our experiments have shown that, generally, this type of hard shutdown will not FIN/RST existing TCP connections (i.e., state ESTABLISHED).
# Now, for the particular case of NeonVM, we just did 'pg_ctl stop'.
# But, the libpagestore.c is currently not explicitly shutting down the TCP connection to pageservers, relying on the kernel
# to implicitly close the socket on exit.
# This sleep here is to give the kernel time to send the FIN/RST.
sleep 1
/neonvm/bin/poweroff
`

Expand Down
Loading