Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pgbouncer to 1.21.0 + support prepared statements #566

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update pgbouncer to 1.21.0 + support prepared statements #566

merged 2 commits into from
Oct 17, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Oct 16, 2023 •
edited
Loading

sharnoff
sharnoff approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it's weird that the pgbouncer config is stored here... I'll open an issue about it; setting it in vm-builder means we're very inflexible.

@sharnoff sharnoff merged commit 23adc18 into main Oct 17, 2023
8 checks passed
@sharnoff sharnoff deleted the bayandin/pgbouncer-1.21.0 branch October 17, 2023 17:24
sharnoff added a commit to neondatabase/neon that referenced this pull request Oct 18, 2023
@sharnoff
Bump vm-builder v0.17.12 -> v0.18.1
bd65f7f 
Only applicable change was neondatabase/autoscaling#566, updating
pgbouncer to 1.21.0 and enabling support for prepared statements.
@sharnoff sharnoff mentioned this pull request Oct 18, 2023
Merged
sharnoff added a commit to neondatabase/neon that referenced this pull request Oct 18, 2023
@sharnoff
Bump vm-builder v0.17.12 -> v0.18.1 (#5583)
16c87b5 
Only applicable change was neondatabase/autoscaling#566, updating
pgbouncer to 1.21.0 and enabling support for prepared statements.
@sharnoff
Copy link
Member

I'll open an issue about it

#577

@bayandin bayandin mentioned this pull request Oct 26, 2023
Merged
bayandin added a commit that referenced this pull request Oct 26, 2023
@bayandin
vm-builder: disable prepared statements support for pgbouncer (#589)
053b34c 
Disable prepared statement support for pgbouncer by setting
`max_prepared_statements=0`.

It was initially enabled in
#566, but we encountered
some problems with them. And we can't just revert that PR (to pgbouncer
1.18) because we started to use `auth_dbname`, which is added in
pgbouncer 1.19.

Ref https://neondb.slack.com/archives/C063B6SCHDX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharnoff sharnoff sharnoff approved these changes

@vadim2404 vadim2404 vadim2404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bayandin @sharnoff @vadim2404