-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm-builder: Turn off --auto-discover-databases #571
Conversation
It causes exporter connection to every database in the Postgres and it was disabled for pods a while ago, but I forgot that VMs have a different build path. See this for details: neondatabase/cloud@0a60057 Also remove `--exclude-databases` it seems to be bogus as well, see: prometheus-community/postgres_exporter#588
Hm, looks like one of the tests fails (
But I don't get what the error is. @sharnoff can you please help with reading this test result? |
Looks like downscale is failing because the vm-monitor is hitting internal errors. Unfortunately we don't have logs for the VMs themselves, but it's unlikely that it's failing because of this PR — each vm-monitor is pulled from neondatabase/neon's current main, so maybe some recent change or something. I'll dig into it further. |
OK, I'd avoid stacking PR on top of failing tests and it's not urgent, so let me know when it makes sense to re-run / safe to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem was fixed with neondatabase/neon#5606, all good to merge.
Filed #577 to track the long term solution for moving postgres_exporter configuration into the control plane (among other things). There's more immediate changes that could be made to make that simpler, if we anticipate needing to do this frequently or with urgency. |
Only applicable change was neondatabase/autoscaling#571, removing the postgres_exporter flags `--auto-discover-databases` and `--exclude-databases=...`
Only applicable change was neondatabase/autoscaling#571, removing the postgres_exporter flags `--auto-discover-databases` and `--exclude-databases=...`
Only applicable change was neondatabase/autoscaling#571, removing the postgres_exporter flags `--auto-discover-databases` and `--exclude-databases=...`
It causes exporter connection to every database in the Postgres and it was disabled for pods a while ago, but I forgot that VMs have a different build path.
See this for details:
https://github.com/neondatabase/cloud/commit/0a60057f3380e570b540cc823975e07400cd640c
Also remove
--exclude-databases
it seems to be bogus as well, see:prometheus-community/postgres_exporter#588