Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add taskgroup #922

Merged
merged 25 commits into from
Jun 17, 2024
Merged

util: add taskgroup #922

merged 25 commits into from
Jun 17, 2024

Conversation

Omrigan
Copy link
Contributor

@Omrigan Omrigan commented Apr 26, 2024

taskgroup.Group is the better version of errgroup.Group with two changes:

  1. Support for multerrors
  2. Logging the errors, when they are returned

Part of #921

Omrigan added 8 commits April 26, 2024 19:06
@Omrigan
import multierrgroup as-is
d32831f 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
rename
7b6e5c1 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
change interface
4b3d8e1 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
hide default ctor
5e848d8 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
change runner into taskgroup
0dc2112 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
fix linter
9bcda71 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
use taskgroup in the agent
38694c2 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
go mod tidy
1602695 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan Omrigan marked this pull request as ready for review May 6, 2024 12:37
@Omrigan Omrigan requested a review from sharnoff May 6, 2024 14:49
sharnoff
sharnoff reviewed May 21, 2024
View reviewed changes
pkg/util/taskgroup/LICENSE Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Show resolved Hide resolved
Omrigan added 3 commits May 21, 2024 17:25
@Omrigan
add panic handler
2c9ee71 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
Merge branch 'main' into oleg/taskgroup
b9bc573 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
fix lints
bf7a5af 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan Omrigan requested a review from sharnoff May 23, 2024 09:36
sharnoff
sharnoff reviewed May 24, 2024
View reviewed changes
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/agent/billing/billing.go Outdated Show resolved Hide resolved
pkg/agent/entrypoint.go Outdated Show resolved Hide resolved
pkg/agent/entrypoint.go Outdated Show resolved Hide resolved
Omrigan added 4 commits May 28, 2024 16:31
@Omrigan
update the API to Ctx()
836b1b0 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
change callsites
f7d0581 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
Merge branch 'main' into oleg/taskgroup
fa4e326 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan
add stack trace
9eff2d3 
Signed-off-by: Oleg Vasilev <[email protected]>
@Omrigan Omrigan requested a review from sharnoff May 28, 2024 13:58
@Omrigan
delete fail
103e184 
Signed-off-by: Oleg Vasilev <[email protected]>
sharnoff
sharnoff reviewed May 28, 2024
View reviewed changes
pkg/agent/entrypoint.go Outdated Show resolved Hide resolved
sharnoff
sharnoff reviewed May 28, 2024
View reviewed changes
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some finer details left, mostly relating to panic handling.

pkg/util/taskgroup/taskgroup.go Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup.go Show resolved Hide resolved
Omrigan and others added 3 commits May 30, 2024 18:23
@Omrigan Omrigan requested a review from sharnoff May 31, 2024 10:47
sharnoff
sharnoff reviewed Jun 7, 2024
View reviewed changes
pkg/util/taskgroup/taskgroup.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup_test.go Show resolved Hide resolved
pkg/util/taskgroup/taskgroup_test.go Outdated Show resolved Hide resolved
pkg/util/taskgroup/taskgroup_test.go Outdated Show resolved Hide resolved
pkg/agent/entrypoint.go Outdated Show resolved Hide resolved
@Omrigan Omrigan requested a review from sharnoff June 10, 2024 09:47
sharnoff
sharnoff approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending a couple comments :)

(I know this one took quite a while; thanks for sticking through it!)

pkg/util/taskgroup/taskgroup_test.go Show resolved Hide resolved
pkg/agent/entrypoint.go Outdated Show resolved Hide resolved
Omrigan
Omrigan commented Jun 17, 2024
View reviewed changes
pkg/agent/entrypoint.go Outdated Show resolved Hide resolved
@Omrigan Omrigan mentioned this pull request Jun 17, 2024
Open
2 tasks
@Omrigan Omrigan enabled auto-merge (squash) June 17, 2024 13:25
@Omrigan Omrigan merged commit 3a61010 into main Jun 17, 2024
15 checks passed
@Omrigan Omrigan deleted the oleg/taskgroup branch June 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharnoff sharnoff sharnoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omrigan @sharnoff