Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codespell #945

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix codespell #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42719c3
lint/codespell: Fix '*.patch' usage
sharnoff May 24, 2024
2fbba92
Make codespell happy (typos, exclude list)
sharnoff May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ jobs:
- uses: codespell-project/actions-codespell@94259cd8be02ad2903ba34a22d9c13de21a74461 # v2.0
with:
check_hidden: true
skip: go.sum,*.patch # '*.patch' references cluster-autoscaler/ca.patch, but somehow skipping directly doesn't work...
ignore_words_list: NotIn # k8s match selectors; codespell tries to correct it to 'noting', 'not in', or 'notion'
skip: go.sum,./cluster-autoscaler/ca.patch

actionlint:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion cluster-autoscaler/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ WORKDIR /workspace

ARG CA_GIT_TAG

# Download the repo. It's... quite large, but thankfuly this should get cached
# Download the repo. It's... quite large, but thankfully this should get cached
RUN git clone --depth=1 -b $CA_GIT_TAG https://github.com/kubernetes/autoscaler

# Only ADD the patch after downloading, to avoid wrecking the cache
Expand Down
2 changes: 1 addition & 1 deletion neonvm/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ status:

### Questions

- how generate name for target VM (name prefix/sufix/other) ?
- how generate name for target VM (name prefix/suffix/other) ?
- how long migration resource should be available (`kubectl get neonvmmigrate`) after migration finished ?
- how to cancel migration ? as variant - just delete it (`kubectl delete neonvmmigrate example`)
- should migration controller delete source VM after migration ?
Expand Down
Loading