neonvm: Remove hack/tools.go #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was originally added in neondatabase/neonvm#4 in order to track the controller-tools version in go.mod, but we switched away from that and started storing it as an env var in the makefile with neondatabase/neonvm#8.
Omrigan
approved these changes
Jun 23, 2024
sharnoff
added a commit
that referenced
this pull request
Jun 24, 2024
These were previously required because of versioning controller-tools in go.mod, but we removed that ni #985, so these replaces aren't needed.
sharnoff
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was originally added in neondatabase/neonvm#4 in order to track the controller-tools version in go.mod, but we switched away from that and started storing it as an env var in the makefile with neondatabase/neonvm#8 (i.e., it's been unused for a while).
Noticed while reviewing #928.