Add metric-collection-endpoint and metric-collection-interval setting… (

#25) * Add metric collection settings to proxy helm chart: metric-collection-endpoint and metric-collection-interval Co-authored-by: Lassi Pölönen <[email protected]>
neondatabase · Jan 16, 2023 · 6c010e1 · 6c010e1
1 parent 50481ae
commit 6c010e1
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/charts/neon-proxy/Chart.yaml b/charts/neon-proxy/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: neon-proxy
 description: Neon Proxy
 type: application
-version: 1.4.0
+version: 1.5.0
 appVersion: "0.1.0"
 kubeVersion: "^1.18.x-x"
 home: https://neon.tech

diff --git a/charts/neon-proxy/README.md b/charts/neon-proxy/README.md
@@ -1,6 +1,6 @@
 # neon-proxy
 
-![Version: 1.4.0](https://img.shields.io/badge/Version-1.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![Lint and Test Charts](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml/badge.svg)](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml)
+![Version: 1.5.0](https://img.shields.io/badge/Version-1.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![Lint and Test Charts](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml/badge.svg)](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml)
 
 Neon Proxy
 
@@ -62,6 +62,8 @@ Kubernetes: `^1.18.x-x`
 | settings.authBackend | string | `"link"` | auth method used (console|link|postgres) |
 | settings.authEndpoint | string | `""` | auth endpoint, e.g. "http://console.neon/authenticate_proxy_request/" |
 | settings.domain | string | `""` | domain used in TLS cert for client postgres connections |
+| settings.metricCollectionEndpoint | string | `""` | (url) endpoint used to send metrics to. If null, metrics will not be sent. |
+| settings.metricCollectionInterval | string | `""` | (string) how often metrics should be sent. |
 | settings.sentryEnvironment | string | `"development"` | "development" or "production". It will be visible in sentry in order to filter issues |
 | settings.sentryUrl | string | `""` | url (will be converted into `SENTRY_DSN` environment variable) used by sentry to collect error/panic events in neon-proxy |
 | settings.uri | string | `""` |  |

diff --git a/charts/neon-proxy/templates/deployment.yaml b/charts/neon-proxy/templates/deployment.yaml
@@ -71,6 +71,14 @@ spec:
             - --auth-backend
             - {{ . }}
             {{- end }}
+           {{- with .Values.settings.metricsCollectionEndpoint }}
+            - --metric-collection-endpoint
+            - {{ . }}
+            {{- end }}
+            {{- with .Values.settings.metricsCollectionInterval }}
+            - --metric-collection-interval
+            - {{ . }}
+            {{- end }}
             {{- end }}
             {{- if .Values.settings.domain }}
             - --tls-key

diff --git a/charts/neon-proxy/values.yaml b/charts/neon-proxy/values.yaml
@@ -36,6 +36,10 @@ settings:
   sentryEnvironment: "development"
   # settings.wssPort -- (int) numeric port used for wss/https connections. If null, wss server will not be started
   wssPort: null
+  # settings.metricCollectionEndpoint -- (url) endpoint used to send metrics to. If null, metrics will not be sent.
+  metricCollectionEndpoint: ""
+  # settings.metricCollectionInterval -- (string) how often metrics should be sent.
+  metricCollectionInterval: ""
 
 serviceAccount:
   # serviceAccount.create - Specifies whether a service account should be created