Inject address for peers at storage controller start-up #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage controller needs to know the address at which it is reachable by it's peers within the deployment. It will use this to mark itself as the leader in the database. The CLI arg was added in neondatabase/neon#8588 and that's already been deployed everywhere. Note that we are not enabling graceful leadership tranfers with this change. The only change in storcon behaviour is that each instance will write its address into the database at start-up. If that fails, the process exits.
VladLazar
force-pushed
the
vlad/external-ip-for-storcon-pods
branch
from
6a30793 to
b3ea006
Compare
jcsp
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage controller needs to know the address at which it is reachable by it's peers within the deployment. It will use this to mark itself as the leader in the database.
The CLI arg was added in neondatabase/neon#8588 and that's already been deployed everywhere.
Note that we are not enabling graceful leadership tranfers with this change. The only change in storcon behaviour is that each instance will write its address into the database at start-up. If that fails, the process exits.