Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy: Add support for additional command line arguments #105

Merged
merged 1 commit into from
Sep 25, 2024
Merged

proxy: Add support for additional command line arguments #105

merged 1 commit into from
Sep 25, 2024

Conversation

rahulinux
Copy link
Contributor

Description

  • Add support for additional command line arguments
  • This will be use to deploy proxy in private access mode i.e. --is-private-access-proxy flag

Ref: https://github.com/neondatabase/cloud/issues/18304

@rahulinux rahulinux requested review from conradludgate and a team September 24, 2024 15:03
@rahulinux rahulinux force-pushed the rahul/update-proxy-flag branch from 3b6fd8e to 791dbbd Compare September 25, 2024 09:13
stradig
stradig approved these changes Sep 25, 2024
View reviewed changes
Copy link

@stradig stradig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rahulinux rahulinux merged commit 6ad0769 into main Sep 25, 2024
6 checks passed
@rahulinux rahulinux deleted the rahul/update-proxy-flag branch September 25, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stradig stradig stradig approved these changes

@Pluggi Pluggi Awaiting requested review from Pluggi

@conradludgate conradludgate Awaiting requested review from conradludgate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahulinux @Pluggi @conradludgate @stradig