Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remoteStorageConfig variable to neon-storage-scrubber #112

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Nov 19, 2024

Adds an object-typed remoteStorageConfig variable to neon-storage-scrubber.

Earlier PR: #88
Part of https://github.com/neondatabase/cloud/issues/19963

@arpad-m arpad-m force-pushed the arpad/scrubber_azure branch from f08da61 to 611c8f6 Compare November 19, 2024 21:28
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bump the version of the helm chart and regenerate docs before approval :) LGTM

Signed-off-by: Alex Chi Z <[email protected]>
@skyzh
Copy link
Member

skyzh commented Nov 20, 2024

Using the config from the private repo, I get something like:

              env:
                - name: REMOTE_STORAGE_CONFIG
                  value:
                    container_name = "<redacted>"
                    container_region = "<redacted>"
                    storage_account = "<redacted>"

I wonder whether this is valid yaml? I thought it should be something like

value: |
  <multi-line string>

hmm...

@skyzh
Copy link
Member

skyzh commented Nov 20, 2024

https://stackoverflow.com/questions/3790454/how-do-i-break-a-string-in-yaml-over-multiple-lines

"Flow" scalar styles ( , ", ')
These have limited escaping, and construct a single-line string with no new line characters. They can begin on the same line as the key, or with additional newlines first, which are stripped. Doubled newline characters become one newline.

ahh, yaml is hard

Signed-off-by: Alex Chi Z <[email protected]>
@skyzh
Copy link
Member

skyzh commented Nov 20, 2024

Manual testing:

helm template charts/neon-storage-scrubber -f ./input.yml > output.yml
cat output.yml | yq  '.spec.jobTemplate.spec.template.spec.containers.[0].env.[0].value'

@arpad-m arpad-m merged commit 4696c02 into main Nov 20, 2024
6 checks passed
@arpad-m arpad-m deleted the arpad/scrubber_azure branch November 20, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants