Propagate proxy values to the container #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpodraza
requested changes
Dec 13, 2023
| - --disable-dynamic-rate-limiter | ||
| - "false" | ||
| {{- end }} | ||
| {{- if .Values.settings.disableDynamicRateLimiter }} |
There was a problem hiding this comment.
Don't you mean?
Suggested change
| {{- if .Values.settings.disableDynamicRateLimiter }} | |
| {{- if .Values.settings.aimdMaxLimit }} |
| {{- end }} | ||
| {{- if .Values.settings.disableDynamicRateLimiter }} | ||
| - --aimd-max-limit | ||
| - {{ . }} |
There was a problem hiding this comment.
You need to pass the setting explicitly, since we're not in a with block:
Suggested change
| - {{ . }} | |
| - {{ .Values.settings.aimdMaxLimit }} |
There was a problem hiding this comment.
Added a with block.
There was a problem hiding this comment.
Does aimdMaxLimit have a default value in values.yaml?
I think for regions that don't specify that it will pass an empty flag to the binary, I'd wrap this in an if block
mattpodraza
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.