Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix quotation of --endpoint-rps-limit in proxy, take 2 #53

Merged
merged 1 commit into from
Dec 17, 2023
Merged

fix quotation of --endpoint-rps-limit in proxy, take 2 #53

merged 1 commit into from
Dec 17, 2023

Conversation

kelvich
Copy link
Contributor

@kelvich kelvich commented Dec 17, 2023

No description provided.

@kelvich kelvich force-pushed the sk/fix_endpointRpsLimits_helm_take2 branch from ded162b to 7b1d354 Compare December 17, 2023 17:50
@kelvich
Copy link
Contributor Author

kelvich commented Dec 17, 2023 •
edited
Loading

now lint fails with error: invalid value '""300@1s""' for '--endpoint-rps-limit <ENDPOINT_RPS_LIMIT>': invalid digit found in string, removing extra "..."

@kelvich kelvich force-pushed the sk/fix_endpointRpsLimits_helm_take2 branch from 7b1d354 to e585646 Compare December 17, 2023 18:03
@kelvich kelvich force-pushed the sk/fix_endpointRpsLimits_helm_take2 branch from e585646 to e224edc Compare December 17, 2023 18:15
@lassizci
Copy link
Contributor

now lint fails with error: invalid value '""300@1s""' for '--endpoint-rps-limit <ENDPOINT_RPS_LIMIT>': invalid digit found in string, removing extra "..."

Seems like the explicit quoting causes double quoting. At least locally works without quote filter in the argument.

@kelvich kelvich merged commit 232c185 into main Dec 17, 2023
3 checks passed
@kelvich kelvich deleted the sk/fix_endpointRpsLimits_helm_take2 branch December 17, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcdm fcdm fcdm approved these changes

@conradludgate conradludgate conradludgate approved these changes

@lassizci lassizci lassizci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kelvich @lassizci @conradludgate @fcdm