Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create http-timeout value #68

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Create http-timeout value #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b1f48e
Create http-timeout value
khanova Mar 4, 2024
2f0701d
Add values
khanova Mar 4, 2024
bc43858
Fix docs
khanova Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/neon-proxy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: neon-proxy
description: Neon Proxy
type: application
version: 1.7.18
version: 1.7.19
appVersion: "0.1.0"
kubeVersion: "^1.18.x-x"
home: https://neon.tech
Expand Down
3 changes: 2 additions & 1 deletion charts/neon-proxy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# neon-proxy

![Version: 1.7.18](https://img.shields.io/badge/Version-1.7.18-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![Lint and Test Charts](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml/badge.svg)](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml)
![Version: 1.7.19](https://img.shields.io/badge/Version-1.7.19-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) [![Lint and Test Charts](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml/badge.svg)](https://github.com/neondatabase/helm-charts/actions/workflows/lint-test.yaml)

Neon Proxy

Expand Down Expand Up @@ -89,6 +89,7 @@ Kubernetes: `^1.18.x-x`
| settings.rustLog | string | `"INFO"` | Proxy log level |
| settings.sentryEnvironment | string | `"development"` | "development" or "production". It will be visible in sentry in order to filter issues |
| settings.sentryUrl | string | `""` | url (will be converted into `SENTRY_DSN` environment variable) used by sentry to collect error/panic events in neon-proxy |
| settings.sqlOverHttpTimeout | string | `"15s"` | (string) timeout for http connection requests |
| settings.uri | string | `""` | |
| settings.useCertManager | bool | `true` | |
| settings.wakeComputeLock | string | `"permits=0"` | (string) Configures the locking of wake_compute per endpoint |
Expand Down
3 changes: 3 additions & 0 deletions charts/neon-proxy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ spec:
- {{ . }}
{{- end }}
{{- end }}
{{- with .Values.settings.sqlOverHttpTimeout }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would usually write just

            - --sql-over-http-timeout={{ .Values.settings.sqlOverHttpTimeout }}

for a single value flag, but looks like we have different convention here. Let's keep as you did.

- --sql-over-http-timeout={{ . }}
{{ end }}
{{- if .Values.settings.httpPoolOptIn }}
- --sql-over-http-pool-opt-in
- "true"
Expand Down
2 changes: 2 additions & 0 deletions charts/neon-proxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ settings:
wakeComputeLock: "permits=0"
# settings.redisNotifications -- (url) Configures redis client
redisNotifications: ""
# settings.sqlOverHttpTimeout -- (string) timeout for http connection requests
sqlOverHttpTimeout: "15s"
# settings.httpPoolOptIn -- (bool) Sets the SQL over HTTP Pool to opt-in-only mode if true. Set false to enable it always
httpPoolOptIn: true
# settings.disableDynamicRateLimiter -- (bool) Disable dynamic rate limiter
Expand Down
Loading