Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage controller registration script #69

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

rahulinux
Copy link
Contributor

@rahulinux rahulinux commented Mar 4, 2024

Cplane only accept node_id as integer and script were sending string.

neon-control-plane-api-0 neon-control-plane {"level":"ERR","ts":"2024-03-04T12:51:53.388Z","logger":"managementapiv2","message":"incoming request finished with error","http_meth":"POST","http_path":"/management/api/v2/pageservers","route":"PageserverRegister","request_id":"8c1da1d9ae780811e3debd558cc261b6","trace_id":"2qCK96h5WSEyyNMa4CB9Qc","ingress_duration_ms":0,"status":400,"error":"invalid request: decode application/json: decode PageserverRegisterRequest: callback: decode field \"node_id\": unexpected byte 34 '\"' at 495: operation PageserverRegister: decode request: decode application/json: decode PageserverRegisterRequest: callback: decode field \"node_id\": unexpected byte 34 '\"' at 495","errorVerbose":"invalid request: decode application/json: decode PageserverRegisterRequest: callback: decode field \"node_id\": unexpected byte 34 '\"' at 495:\n    github.com/neondatabase/cloud/internal/semerr.errFmt\n        /build/internal/semerr/semantic.go:65\n  - operation PageserverRegister: decode request:\n      - decode application/json:\n        body: {\"host\": \"storage-controller.beta.us-east-2.internal.aws.neon.build\", \"region_id\": \"aws-us-east-2\", \"port\": 6400, \"disk_size\": 0, \"instance_id\": \"storage-controller.beta.us-east-2.internal.aws.neon.build\", \"http_host\": \"storage-controller.beta.us-east-2.internal.aws.neon.build\", \"http_port\": 50051, \"availability_zone_id\": \"us-east-2c\", \"instance_type\": \"\", \"register_reason\": \"Storage Controller Virtual Pageserver\", \"active\": false, \"is_storage_controller\": true, \"version\": 4767, \"node_id\": \"9315\"}\n

@rahulinux rahulinux force-pushed the fix/register-storage-controller branch from 1f31c6d to bf39a5c Compare March 4, 2024 15:20
@rahulinux rahulinux requested a review from a team March 4, 2024 15:23
@rahulinux rahulinux merged commit 2e483a3 into main Mar 4, 2024
3 checks passed
@rahulinux rahulinux deleted the fix/register-storage-controller branch March 4, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants