storage controller: don't | quote split threshold

[jcsp]

Helm (or Go formatting more generally) apparently arbitrarily uses scientific notation for integers above a million when quoting.

Try passing it through without the | quote to see if a simple integer makes it through unscathed.

[petuhovskiy]

Sounds more like a yaml issue, maybe we should put splitThreshold value in quotes at .github/helm-values/dev-us-east-2-beta.neon-storage-controller.yaml:69?

[petuhovskiy]

This is probably the issue: go-yaml/yaml#730

UPD: looked again, probably a different issue after all

[jcsp]

maybe we should put splitThreshold value in quotes at .github/helm-values/dev-us-east-2-beta.neon-storage-controller.yaml:69

I have a PR to do that, but I'm interested to see if it's really necessary -- the YAML is allowed to use scientific notation, as long as the string substitution in the helm template handles that as an int rather than string.
So I'd like to try just this PR first, then only merge https://github.com/neondatabase/aws/pull/1358 if necessary.

[petuhovskiy]

Ok, let's try removing | quote.

But I think that underlying issue is that large numbers in yaml got parsed as float64 by default, and default "to string" implementation for floats is to use scientific notation.