Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage-scrubber: enable jwt auth with storage controller #93

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Aug 5, 2024

This pull request adds 3 fields to the helm chart to support scrubber<->controller auth.

  # -- Enable storage controller related functionalities
  enableStorageControllerConnection: false
  # -- Control plane / storage controller JWT token for connecting to the storage controller
  storageControllerJwtToken: ""
  # -- URL of the storage controller
  storageControllerUrl: ""

Also, users no longer need to supply the executable path in the command field.

Tested by deploying this chart to dev-us-east-2 and it works.

@skyzh skyzh force-pushed the skyzh/storage-controller-jwt branch from 0fa8bea to b1ff185 Compare August 5, 2024 05:06
@skyzh skyzh force-pushed the skyzh/storage-controller-jwt branch from b1ff185 to 7f04ca0 Compare August 5, 2024 05:09
Signed-off-by: Alex Chi Z <[email protected]>
@skyzh skyzh marked this pull request as ready for review August 5, 2024 07:30
@skyzh skyzh requested review from cicdteam and rahulinux August 5, 2024 07:30
@skyzh skyzh merged commit ed91bdb into main Aug 5, 2024
3 checks passed
@skyzh skyzh deleted the skyzh/storage-controller-jwt branch August 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants