Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user's email as ID as a fallback for Vercel auth. #25

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

dsavelev
Copy link
Contributor

@dsavelev dsavelev commented Oct 3, 2024

No description provided.

@dsavelev dsavelev requested review from kszafran and Daniel-ef October 3, 2024 22:42
@dsavelev dsavelev requested a review from kszafran October 4, 2024 10:46
Copy link
Collaborator

@adi-griever adi-griever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: have you given consideration to how it's going to work with email change?

@dsavelev
Copy link
Contributor Author

dsavelev commented Oct 4, 2024

General comment: have you given consideration to how it's going to work with email change?

What do you mean? Right now we don't have any VercelMP users in production, so it will not affect anybody. Or do you have some other concerns?

kszafran
kszafran previously approved these changes Oct 4, 2024
@dsavelev dsavelev force-pushed the dsavelev/use-email-as-id branch from 618ec62 to 2c79b78 Compare October 4, 2024 11:00
@dsavelev dsavelev merged commit f60e4e8 into main Oct 4, 2024
4 checks passed
@dsavelev dsavelev deleted the dsavelev/use-email-as-id branch October 4, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants